Feat: Add sha1 function impl #2471
Open
+23
−4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
comphead
reviewed
Sep 29, 2025
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2471 +/- ##
============================================
+ Coverage 56.12% 58.60% +2.47%
- Complexity 976 1400 +424
============================================
Files 119 146 +27
Lines 11743 13753 +2010
Branches 2251 2355 +104
============================================
+ Hits 6591 8060 +1469
- Misses 4012 4448 +436
- Partials 1140 1245 +105 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
added 3 commits
September 30, 2025 14:24
# Conflicts: # native/core/src/execution/jni_api.rs
comphead
reviewed
Oct 14, 2025
| inputs: Seq[Attribute], | ||
| binding: Boolean): Option[ExprOuterClass.Expr] = { | ||
| if (!HashUtils.isSupportedType(expr)) { | ||
| return None |
There was a problem hiding this comment.
lets return a fallback reason like
if (!isTypeSupported(dt)) {
withInfo(expr, s"data type not supported: $dt")
return None
}
comphead
reviewed
Oct 14, 2025
|
@kazantsev-maksim I took the liberty to modify the PR, waiting the CI |
added 2 commits
October 17, 2025 21:58
|
@comphead do you have any ideas what the problem might be? I couldn't reproduce the problem on my local machine... |
|
Checking |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Part of: #2443
Rationale for this change
Part of: #2443
What changes are included in this PR?
How are these changes tested?
A new UT has been added.